This is the mail archive of the
gdb-patches@sourceware.cygnus.com
mailing list for the GDB project.
Re: [MAINT/PATCH] ChangeLog et.al.: Revert whitespace changes
- To: Eli Zaretskii <eliz at is dot elta dot co dot il>
- Subject: Re: [MAINT/PATCH] ChangeLog et.al.: Revert whitespace changes
- From: Andrew Cagney <ac131313 at cygnus dot com>
- Date: Mon, 03 Apr 2000 12:14:14 +1000
- CC: gdb-patches at sourceware dot cygnus dot com
- Organization: Cygnus Solutions
- References: <38DEF05E.9D2E79AC@cygnus.com> <200003312332.SAA07205@indy.delorie.com>
Eli Zaretskii wrote:
>
> > I've just committed the attatched. It reverts a string of arbitrary
> > whitespace changes made to various files including ChangeLogs.
> >
> > For ChangeLogs, they should be prepend-only.
>
> Sorry, I don't understand some of these changes, like this one:
>
> > *************** Fri Mar 17 11:06:59 2000 Philippe De Mu
> > *** 429,435 ****
> > * config/i386/tm-linux.h (I386_LINUX_SIGTRAMP): No need to define
> > this any more, since we're not enabling OS-specific code in a
> > OS-independent file.
> > !
> > 2000-03-16 Eli Zaretskii <eliz@is.elta.co.il>
> >
> > * Makefile.in (go32-nat.o): Add prerequisites.
> > --- 433,439 ----
> > * config/i386/tm-linux.h (I386_LINUX_SIGTRAMP): No need to define
> > this any more, since we're not enabling OS-specific code in a
> > OS-independent file.
> > !
> > 2000-03-16 Eli Zaretskii <eliz@is.elta.co.il>
> >
> > * Makefile.in (go32-nat.o): Add prerequisites.
>
> The only change here is that in the new version, there's extra
> whitespace in an otherwise empty line. It's quite possible that some
> editor (such as Emacs) removed the whitespace when somebody pressed
> M-q to reformat the paragraph.
It is more than just M-q - I use that all the time and yet I don't
commit arbitrary white space changes. What I assume is happening is an
editor (probably emacs) has has been configured to strip/modify white
space changes in a arbitrary way when ever it touches a file.
People should only pre-pend additions to ChangeLog (ignoring the
occasional sneekered typo fix :-). Otherwise we end up with the bizare
situtation of each successive commit re- write-spacing the file :-/
enjoy,
Andrew