This is the mail archive of the gdb-patches@sourceware.cygnus.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: PATCH/RFA : copying.c & copying.txt


Andrew Cagney wrote :
> Philippe De Muyter wrote:
> > 
> > Do you already know that Eli's recent copying.txt change causes build failure
> > for gdb ?
> 
> Hmm, it is make dependant. GNU make finds copying.c in the src directory
> and just uses that.

I use GNU make (version 3.71), and I surmise that it now `knows' that copying.c
requires copying.txt, so it builds it, but then copying.txt is newer than
copying.c, so copying.c must be remade with the rule that I proposed to patch.

> This also suggests what I suspect is the correct solution - copying.c
> should only be dependant on COPYING when ``maintainer-mode'' is enabled.

That is also true.

> 
> 	Andrew
> 
> > 
> > The patch below fixes that. OK to commit ?
> > 
> > Philippe De Muyter  <phdm@macqel.be>
> > 
> >         * Makefile.in (copying.c): Build from `copying.txt', not
> >         `$(srcdir)/copying.txt'.
> > 
> > Index: gdb/Makefile.in
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/Makefile.in,v
> > retrieving revision 1.25
> > diff -u -p -r1.25 Makefile.in
> > --- Makefile.in 2000/04/09 14:37:28     1.25
> > +++ Makefile.in 2000/04/10 10:14:38
> > @@ -954,7 +954,7 @@ copying.txt:
> > 
> >  # Make copying.c from COPYING
> >  copying.c: copying.txt copying.awk
> > -       awk -f $(srcdir)/copying.awk < $(srcdir)/copying.txt > copying.c
> > +       awk -f $(srcdir)/copying.awk < copying.txt > copying.c
> > 
> >  version.c: Makefile
> >         rm -f version.c
> 


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]