This is the mail archive of the
gdb-patches@sourceware.cygnus.com
mailing list for the GDB project.
Re: PATCH: thread.c syntax fix
- To: Robert Lipe <robertl at sco dot com>
- Subject: Re: PATCH: thread.c syntax fix
- From: Michael Snyder <msnyder at cygnus dot com>
- Date: Fri, 28 Apr 2000 18:28:17 -0700
- CC: gdb-patches at sourceware dot cygnus dot com
- Organization: Cygnus Solutions
- References: <20000123152735.A7047@rjlhome.sco.com>
Robert Lipe wrote:
>
> If a fn isn't proto'ed before it's seen it's assumed to return an
> int. Some compilers will issue diagnostics about the function type
> redeclaration.
>
> RJL
Hi Robert,
Pardon the long time lag -- I was on sabbatical, and I had not
caught up on mailing lists.
I can't make it static, 'cause it's used by another module now;
and I notice there is a prototype in defs.h (maybe there wasn't
when you submitted this).
Michael
>
> 2000-01-23 Robert Lipe (robertl@sco.com)
>
> * thread.c (gdb_thread_select): Make static. Add prototype
> before first use.
>
> Index: thread.c
> ===================================================================
> RCS file: /cvs/gdb/gdb/gdb/thread.c,v
> retrieving revision 1.1.1.10
> diff -u -p -r1.1.1.10 thread.c
> --- thread.c 2000/01/18 00:54:12 1.1.1.10
> +++ thread.c 2000/01/23 21:27:00
> @@ -59,6 +59,7 @@ static void thread_apply_command PARAMS
> static void restore_current_thread PARAMS ((int));
> static void switch_to_thread PARAMS ((int pid));
> static void prune_threads PARAMS ((void));
> +static enum gdb_rc gdb_thread_select PARAMS ((char *));
>
> void
> init_thread_list ()
> @@ -655,7 +661,7 @@ see the IDs of currently known threads."
> return GDB_RC_OK;
> }
>
> -enum gdb_rc
> +static enum gdb_rc
> gdb_thread_select (char *tidstr)
> {
> return catch_errors (do_captured_thread_select, tidstr,