This is the mail archive of the gdb-patches@sourceware.cygnus.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [RFA] Cygwin/Windows compatibility patches for tcl


On Tue, Jun 06, 2000 at 05:12:26PM +1000, Andrew Cagney wrote:
>Syd Polk wrote:
>> 
>> At 06:56 PM 6/5/00 -0400, Chris Faylor wrote:
>> >I'm not sure if this is the best location for tcl patches but since they
>> >relate to problems with insight, I guess it sort of make sense.  I've
>> >also Cc'ed Syd Polk, who approves the tcl/tk/itcl/tix changes in
>> >sourceware.
>> >
>> >This patch corrects several problems that Cygwin users are seeing with
>> >Insight for Windows.  I'm a little puzzled as to why the slash to backslash
>> >conversion code is in tcl at all but its removal solves the cygwin insight
>> >problems.
>> 
>> I actually think that the backslash reversal code is remnants from another
>> project from within Cygnus.
>> 
>> >Ok to check in?
>> 
>> Please.
>
>FYI,
>
>I reverted a part of the code (see attached) - it dejagnu (tcl) couldn't
>compile :-(.  I suspect it was ment to be #ifcygwin #else #endif.
>
>Hope you don't mind.

Ok.  The problem was that I had a typo in the ifndef block.  I must have started
to make a change for cygwin and then realized that it wasn't necessary.

I've removed the offending line and checked in the patch below.  I've
also checked that this compiles for both Linux and Windows.

cgf

Tue Jun  6 12:17:46 2000  Christopher Faylor <cgf@cygnus.com>

        * generic/tclFilename.c (Tcl_TranslateFileName): Reinstate Mon Jun 5
        18:18:32 2000 Christopher Faylor <cgf@cygnus.com> minus a typo.

Index: generic/tclFileName.c
===================================================================
RCS file: /cvs/src/src/tcl/generic/tclFileName.c,v
retrieving revision 1.3
retrieving revision 1.4
diff -u -r1.3 -r1.4
--- tclFileName.c	2000/06/06 07:07:38	1.3
+++ tclFileName.c	2000/06/06 16:18:48	1.4
@@ -963,6 +963,7 @@
      * some system interfaces don't accept forward slashes.
      */
 
+#ifndef __CYGWIN__
     if (tclPlatform == TCL_PLATFORM_WINDOWS) {
 	for (p = Tcl_DStringValue(bufferPtr); *p != '\0'; p++) {
 	    if (*p == '/') {
@@ -970,6 +971,7 @@
 	    }
 	}
     }
+#endif
     return Tcl_DStringValue(bufferPtr);
 }
 

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]