This is the mail archive of the gdb-patches@sourceware.cygnus.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH RFA] Pascal language part 4: Changes to symfile.c


   Date: Mon, 19 Jun 2000 12:22:58 +0200
   From: Pierre Muller <muller@cerbere.u-strasbg.fr>

     This patch covers the changes to symfile.c
   needed to incoporate pascal support into GDB.

   ChangeLog entry:

   2000-06-19  Muller Pierre <muller@ics.u-strasbg.fr>
      * symbole.c: recognize ".pas" ".p" ".pp" and ".inc" as standard pascal
   source file extensions.

Hi Pierre,

A few comments on this one:

 * Isn't the ".inc" extension for Pascal "include" files?  If so, I'm
   not sure whether the extension should be added, since C includes
   ("*.h") aren't mentioned either.

 * Please keep the formatting uniform.  You try to line-up the
   "language_pascal"s but none of the other languages do that.

 * You might want to put your family name last in the ChangeLog entry,
   otherwise people may start to worry whether Muller Pierre and
   Pierre Muller are one and the same person or not :-).

Mark

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]