This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: patch for sparc-tdep.c for NetBSD/sparc.


    Date: Thu, 13 Jul 2000 10:41:33 -0700
    From: Michael Snyder <msnyder@cygnus.com>

    Mark Kettenis wrote:
    > 
    >    Date: Thu, 13 Jul 2000 09:33:27 -0700
    >    From: Michael Snyder <msnyder@redhat.com>
    > 
    >    matthew green wrote:
    >    >
    >    > i copied the following lines from alphabsd-nat.c, and this allows
    >    > gdb-current to successfully configure, build & run under NetBSD/sparc.
    >    >
    >    > would someone please apply this patch?
    >    >
    >    > thanks,
    >    >
    >    > .mrg.
    > 
    >    It looks OK to me.  David?
    > 
    >    >
    >    > 2000-07-13  matthew green  <mrg@redhat.com>
    >    >
    >    >         * sparc-tdep.c (gregset_t): Define as `struct reg' if undefined.
    >    >         (fpregset_t): Define as `struct fpreg' if undefined.
    > 
    > Shouldn't the NetBSD config headers define GDB_FPREGSET_T and
    > GDB_FPREGSET_T instead?

    Hmm... good point!  Matthew?

I tend to agree with Mark as well.

Unless there is good reason to believe that the proposed defaults of
'struct reg' and 'struct fpreg' are good for most systems, I think
that the NetBSD/sparc configuration should have appropriate defines
of GDB_GREGSET_T and GDB_FPREGSET_T added to one of its header files.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]