This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

re: patch for sparc-tdep.c for NetBSD/sparc.


    Date: Fri, 14 Jul 2000 14:48:06 +1000
    From: matthew green <mrg@cygnus.com>

	   > Shouldn't the NetBSD config headers define GDB_FPREGSET_T and
	   > GDB_FPREGSET_T instead?

	   Hmm... good point!  Matthew?

       I tend to agree with Mark as well.

       Unless there is good reason to believe that the proposed defaults of
       'struct reg' and 'struct fpreg' are good for most systems, I think
       that the NetBSD/sparc configuration should have appropriate defines
       of GDB_GREGSET_T and GDB_FPREGSET_T added to one of its header files.


    um...something like this?  it works for me.


    2000-07-14  matthew green  <mrg@redhat.com>

	    * config/sparc/nm-nbsd.h (gregset_t): Define as `struct reg' if
	    undefined.
	    (fpregset_t): Define as `struct fpreg' if undefined.


This looks fine by me.

Also, I think it needs the approval of the NetBSD maintainer
(J.T. Conklin) rather than my approval, but it looks fine by me.
I have no access to a NetBSD system.

    Index: config/sparc/nm-nbsd.h
    ===================================================================
    RCS file: /cvs/src/src/gdb/config/sparc/nm-nbsd.h,v
    retrieving revision 1.1.1.3
    diff -p -r1.1.1.3 nm-nbsd.h
    *** nm-nbsd.h   1999/12/14 01:05:42     1.1.1.3
    --- nm-nbsd.h   2000/07/14 04:46:33
    ***************
    *** 53,56 ****
    --- 53,64 ----
      #define PTRACE_SETREGS         PT_SETREGS
      #define PTRACE_SETFPREGS PT_SETFPREGS

    + #ifndef HAVE_GREGSET_T
    + typedef struct reg gregset_t;
    + #endif
    + 
    + #ifndef HAVE_FPREGSET_T
    + typedef struct fpreg fpregset_t;
    + #endif
    + 
      #endif /* NM_NBSD_H */

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]