Re: [PATCH]: gas/sim/opcodes Warnings

[Dave Brolley <brolley at redhat dot com>]

It's been brought to my attention that only the
sim/common/cgen-par.[ch] changes apply to this list. I will
submit the rest to the binutils list.

Below are the relevent patches for this list.

Dave

Dave Brolley wrote:
> 
> Hi,
> 
> The attached patch gets rid of some warnings when building
> gas/sim/opcodes. Most of them are unused parameters and integer
> signedness. The only thing I'm not sure about is whether it's
> permissable to use ATTRIBUTE_UNSIGNED in this code.
> 
> Seeking approval to commit this.
> 
> Dave
> 
>   -----------------------------------------------------------------

> Index: sim/common/cgen-par.c
> ===================================================================
> RCS file: /cvs/src/src/sim/common/cgen-par.c,v
> retrieving revision 1.3
> diff -c -p -r1.3 cgen-par.c
> *** cgen-par.c  2000/04/05 22:31:29     1.3
> --- cgen-par.c  2000/07/13 21:21:21
> *************** void sim_queue_fn_si_write (
> *** 107,113 ****
> 
>   void sim_queue_fn_sf_write (
>     SIM_CPU *cpu,
> !   void (*write_function)(SIM_CPU *cpu, UINT, SF),
>     UINT regno,
>     SF value
>   )
> --- 107,113 ----
> 
>   void sim_queue_fn_sf_write (
>     SIM_CPU *cpu,
> !   void (*write_function)(),
>     UINT regno,
>     SF value
>   )
> Index: sim/common/cgen-par.h
> ===================================================================
> RCS file: /cvs/src/src/sim/common/cgen-par.h,v
> retrieving revision 1.3
> diff -c -p -r1.3 cgen-par.h
> *** cgen-par.h  2000/04/05 22:31:29     1.3
> --- cgen-par.h  2000/07/13 21:21:21
> *************** extern void sim_queue_pc_write (SIM_CPU
> *** 189,195 ****
>   extern void sim_queue_fn_hi_write (SIM_CPU *, void (*)(SIM_CPU *, UINT, UHI), UINT, UHI);
>   extern void sim_queue_fn_si_write (SIM_CPU *, void (*)(SIM_CPU *, UINT, USI), UINT, USI);
>   extern void sim_queue_fn_sf_write (SIM_CPU *, void (*)(SIM_CPU *, UINT, SF), UINT, SF);
> ! extern void sim_queue_fn_di_write (SIM_CPU *, void (*)(SIM_CPU *, UINT, DI), UINT, DI);
>   extern void sim_queue_fn_df_write (SIM_CPU *, void (*)(SIM_CPU *, UINT, DF), UINT, DF);
>   extern void sim_queue_fn_xi_write (SIM_CPU *, void (*)(SIM_CPU *, UINT, SI *), UINT, SI *);
>   extern void sim_queue_fn_pc_write (SIM_CPU *, void (*)(SIM_CPU *, USI), USI);
> --- 189,195 ----
>   extern void sim_queue_fn_hi_write (SIM_CPU *, void (*)(SIM_CPU *, UINT, UHI), UINT, UHI);
>   extern void sim_queue_fn_si_write (SIM_CPU *, void (*)(SIM_CPU *, UINT, USI), UINT, USI);
>   extern void sim_queue_fn_sf_write (SIM_CPU *, void (*)(SIM_CPU *, UINT, SF), UINT, SF);
> ! extern void sim_queue_fn_di_write (SIM_CPU *, void (*)(), UINT, DI);
>   extern void sim_queue_fn_df_write (SIM_CPU *, void (*)(SIM_CPU *, UINT, DF), UINT, DF);
>   extern void sim_queue_fn_xi_write (SIM_CPU *, void (*)(SIM_CPU *, UINT, SI *), UINT, SI *);
>   extern void sim_queue_fn_pc_write (SIM_CPU *, void (*)(SIM_CPU *, USI), USI);