This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH] dejagnu lib/framework.exp


Jimmy, your patch is correct.  Having it as global prevents someone to
mistakenly set it on the test file and calling pass from inside a proc
and causing it not to see it.

However, I am not aware of ay test that sets this (used to xfail depending
on compiler flags used).

And it is probably unrelated to your problem as well.

But please check this in so both pass and fail look the same.

Thanks.

Fernando



Jimmy Guo wrote:
> 
> After picking up updates during the past ~30 days, gdb testing
> sporadically issues UNRESOLVED messages for test points that look
> perfectly fine (and there's no usual error / warning messages
> accompanying these UNRESOLVED messages).
> 
> While I'm still scratching my head to root cause this annoyance, here is
> a patch to the only one of a tiny number of dejagnu updates that is
> questionable: compiler_conditional_xfail_data was made a global in
> 'proc fail' ... to be consistent 'proc pass' needs to do the same thing
> as well.  However I'm not sure if somehow this would fix my problem ...
> 
> Fri Jul 28 13:39:27     Jimmy Guo       <guo@cup.hp.com>
> 
>         * lib/framework.exp (pass): make compiler_conditional_xfail_data
>         a global, corresponding to a recent change to 'proc fail'.
> 
> Index: lib/framework.exp
> /usr/local/bin/diff -c -L lib/framework.exp lib/framework.exp@@/main/cygnus/5 lib/framework.exp
> *** lib/framework.exp
> --- lib/framework.exp   Fri Jul 28 13:38:25 2000
> ***************
> *** 672,685 ****
>   # Record that a test has passed
>   #
>   proc pass { message } {
> !     global xfail_flag
> 
>       # if we have a conditional xfail setup, then see if our compiler flags match
> !     if [uplevel {info exists compiler_conditional_xfail_data}] {
> !       if [uplevel {check_conditional_xfail $compiler_conditional_xfail_data}] {
>             set xfail_flag 1
>         }
> !       uplevel {unset compiler_conditional_xfail_data}
>       }
> 
>       if $xfail_flag {
> --- 672,685 ----
>   # Record that a test has passed
>   #
>   proc pass { message } {
> !     global xfail_flag compiler_conditional_xfail_data
> 
>       # if we have a conditional xfail setup, then see if our compiler flags match
> !     if [ info exists compiler_conditional_xfail_data ] {
> !       if [check_conditional_xfail $compiler_conditional_xfail_data] {
>             set xfail_flag 1
>         }
> !       unset compiler_conditional_xfail_data
>       }
> 
>       if $xfail_flag {

-- 
Fernando Nasser
Red Hat - Toronto                       E-Mail:  fnasser@cygnus.com
2323 Yonge Street, Suite #300           Tel:  416-482-2661 ext. 311
Toronto, Ontario   M4P 2C9              Fax:  416-482-6299

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]