Re: [PATCH] dejagnu runtest.exp cleanup

[Fernando Nasser <fnasser at cygnus dot com>]

Jimmy,

It is sort of standard in the current dejagnu code to look for an environment variable 
if the variable is not defined.  Is there a specific reason why you want to remove it
(like, it is conflicting with some environment variable that is frequently defined on HP)?

Can't we just leave it there for the sake of code coherence?

Thanks,
F.


Jimmy Guo wrote:
> 
> Mon Jul 31 16:45:29     Jimmy Guo       <guo@cup.hp.com>
> 
>         * runtest.exp: Cleanup reference to $env(MULTIPASS) and
>         $env(PASS).  These were added by HP but unused since.
> 
> Index: runtest.exp
> /usr/local/bin/diff -c -L runtest.exp runtest.exp@@/main/cygnus/6 runtest.exp
> *** runtest.exp
> --- runtest.exp Mon Jul 31 16:43:59 2000
> ***************
> *** 1604,1623 ****
> 
>       if { [info exists MULTIPASS] } {
>         set multipass $MULTIPASS
> -     } elseif {[info exists env(MULTIPASS)]} {
> -       set multipass $env(MULTIPASS)
>       }
>       if { $multipass == "" } {
>         set multipass { "" }
>       }
> 
> ! # If PASS is specified, either as a TCL variable or in environment, we
> ! # want to run only the tests specified. Its value should be a number
> ! # or a list of numbers that specify the passes that we want to run.
>       if [info exists PASS] {
>         set pass $PASS
> -     } elseif [info exists env(PASS)] {
> -       set pass $env(PASS)
>       } else {
>         set pass ""
>       }
> --- 1604,1619 ----
> 
>       if { [info exists MULTIPASS] } {
>         set multipass $MULTIPASS
>       }
>       if { $multipass == "" } {
>         set multipass { "" }
>       }
> 
> ! # If PASS is specified, we want to run only the tests specified.
> ! # Its value should be a number or a list of numbers that specify
> ! # the passes that we want to run.
>       if [info exists PASS] {
>         set pass $PASS
>       } else {
>         set pass ""
>       }

-- 
Fernando Nasser
Red Hat Canada Ltd.                     E-Mail:  fnasser@cygnus.com
2323 Yonge Street, Suite #300           Tel:  416-482-2661 ext. 311
Toronto, Ontario   M4P 2C9              Fax:  416-482-6299