This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: recent dejagnu changes
- To: Geoff Keating <geoffk at cygnus dot com>
- Subject: Re: recent dejagnu changes
- From: Jimmy Guo <guo at cup dot hp dot com>
- Date: Fri, 4 Aug 2000 22:31:55 -0700 (PDT)
- Cc: gdb-patches at sourceware dot cygnus dot com
>is the one that breaks the GCC testsuite. As far as I can see, it can
>never be a correct change. It's not possible to change the GCC
>testsuite to match, because old versions of the testsuite need to work
>too.
Why? We've been using it on GDB testsuite for months now. What breaks
now for GCC? I'm just curious -- backing it out in the repository is
fine, esp. if it breaks in some env ... but some details on why you
think so would be helpful ...
>I also think that this change:
>
>* lib/target.exp (default_target_compile,default_target_assemble,
>default_link): Remove env() interface for *_FOR_TARGET TCL vars.
>
>and this change:
>
>* runtest.exp: Cleanup reference to $env(MULTIPASS) and
>$env(PASS). These were added by HP but unused since.
>
>are unwise. I don't know what might depend on this functionality.
These were unfortunately added in by yours truly last year. If you want
to back it out it's fine as well.
>They also seem to be part of the same patch judging by the ChangeLog
>entry.
Somehow emacs Ctrl-x 4 a does not create a new date stamp for separate
commits in ChangeLog .. these are actually separate. But I can see how
it could be confusing.
>So I propose to revert all of the recent changes except for those to
>lib/framework.exp. I've tested this patch by running the resulting
>dejagnu against the gcc and gdb testsuites, and running its own
>testsuite, under powerpc-linux X powerpc-eabisim; the results were
>very bad for gdb ("gdb-internal-error: legacy_register_name: called"),
>but the testsuite seemed to be doing the right thing.
Actually the patches work OK in our environment ... but as I said feel
free to back it out if we understand how it breaks ... I submitted
these, except for the env cleanup one, intending to fix something.
- Jimmy Guo, guo@cup.hp.com