Re: [PRELIMINARY]: base port of gdb to IBM S390

[Andrew Cagney <ac131313 at cygnus dot com>]

> IBM would like to submit a base port of GDB to linux running
> on their s390 mainframe.  I'm lending a hand.  I don't have
> changelog entries from them yet...
> 
>         [IBM -- could you submit ChangeLog entries please?]
> 
> but here is the patch.  Besides GDB, this patch affects
> bfd, opcodes, and readline.  Here is a list of the GDB
> files affected (I assume that those with "s390" in the
> name can be accepted virtually as is).  Anyone want to
> jump in and look over the configure changes?

Many of the changes will need to be steered through binutils@sources.

However, some very brief comments from what I glanced at:

	o	Since this code is being submitted post
		5.0 release and it is a brand new port.
		It is going to need to be updated to
		use the multi-arch framework.

		Have a look at the recently added
		hc11 port for the suggested config tweeks.

		I would note that the native won't need
		to be multi-arched.  Just s390-tdep.c
		needs to be.

Looking more generally, I noticed:

	o	I suspect it can't be built as a cross debugger
		The code snippit:

+#ifdef linux
+#include <asm/types.h>
+#include <asm/user.h>
+#include <asm/s390-gdbregs.h>
+#define BREAKPOINT S390_BREAKPOINT
+#define KERNEL_U_SIZE sizeof(struct user)


		from tm-s390.h just looks wrong.  It should
		be possible to build something like:

			./configure --target=s390-linux
			make

		on non 390-linux system


	o	Since this is post 5.0 all
		the K&R ism's can go.


	o	A review of the GNU coding standard
		is in order.


	o	xm-linux.h contains #define HAVE_TERMIOS.
		From memory autoconf handles that now.


	o	xm-linux.h contains #define KERNEL_U_ADDR 0x0
		should that be in the nm-linux.h file?


	o	a review of gdb/doc/gdbint.texi for any deprecated
		macros is needed.


	enjoy,
		Andrew