Re: [PATCH RFC] Protoize m32r-stub.c, m88k-nat.c, m88k-tdep.c

[Kevin Buettner <kevinb at cygnus dot com>]

On Sep 15, 11:04am, Stan Shebs wrote:

> "J.T. Conklin" wrote:
>
> > Should we consider not protoizing the *-stub.c files?  While these are
> > distributed with GDB, they are code that is going to be hacked to bits
> > as they are integrated into a remote target.  While user is probably
> > using gcc, it may be reasonable to be as conservative we can when it
> > comes to these files...
> 
> It's a pretty safe bet that all m32r compilers are ISO!  I thought
> about the stub code standard a while back, and concluded that since
> the stubs are effectively example code, they at least ought to be
> *good* examples.  In fact, they're probably the most-looked-at sources
> in the whole GDB tree, so they should be exemplars of our recommended
> coding practices (suitably adjusted for the embedded case of course).

Okay, I'm confused.  Stan, are you suggesting that I leave the
prototypes in?