This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH]: C++ mangling patch that is about to be committed


Michael Snyder <msnyder@redhat.com> writes:

> Daniel Berlin wrote:
> > 
> > Elena Zannoni <ezannoni@cygnus.com> writes:
> > 
> > > Daniel,
> > >
> > > There is an extra change in symtab.h that has nothing to do with the
> > > changelog. I think that is part of a different patch.
> > No, I missed the changelog entry for it, stupidly.
> > 
> > > BTW, I thought
> > > we agreed to leave the do--while construct in the
> > > SYMBOL_INIT_DEMANGLED_NAME macro.
> > I'd rather not.
> > It's not used in if statements, and *never* should be.
> > The argument that someone, someday, might want to, just isn't
> > convincing, because they shouldn't.
> 
> Umm... Daniel, did you and Elena discuss it?

Elena didn't participate in that discussion, it was held on
gdb-patches in clear view.

> Overriding her opinion by taking it out of a file
> that she maintains and creating a new one that you
> maintain does NOT seem to be in the spirit of
> maintainership...
Err, i'm not.
It's always been in symtab.h
I don't plan on moving that macro to cp-support.h,.
What made you think it was being taken out of a file she maintains,
and moved to one i maintain.
Elena is the backup maintainer.
THat's part of the whole problem.
The maintainer hasn't participated in maintaining the file in a while.
Like I said, since this stuff isn't in my maintainership, i'm not
fixing it anymore.
Someone else can fix it, whether it affects C++ support or not.
That is what part of being  a maintainer is, right? Maintaining?

It's interesting that you seem to be bashing my plan to move the C++
support specific things to cp-support.c, out of places they don't
belong (this is what i'm assuming you think i'm doing when you say
moving things out of a file someone else maintains, and into one i
maintain), since nobody maintains them but me, because they are C++ specific.

I'm expected to look at problems related to them, and fix them, rather
than the person whose maintainership they do fall under, yet I have
to get the patches approved by other people, since i'm not supposed to
maintain them. So i'm to maintain them, but not maintain them.  Weird.
Nobody else has fixed this stuff in years, so it's not a matter of me
just getting to it first.


--Dan



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]