This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH RFA] solib.c reorg
- To: gdb-patches at sourceware dot cygnus dot com
- Subject: Re: [PATCH RFA] solib.c reorg
- From: Kevin Buettner <kevinb at cygnus dot com>
- Date: Tue, 24 Oct 2000 13:27:36 -0700
- References: <1001023030642.ZM11545@ocotillo.lan>
On Oct 22, 8:06pm, Kevin Buettner wrote:
> I request approval for committing the patch below.
>
> This patch reorganizes solib.c as follows:
[...]
Committed.
Thanks to Peter Schauer for reviewing my patch and suggesting
improvements. I have already incorporated his suggestion regarding
the removal of the HAVE_LINK_H ifdef from _initialize_solib().
I'll follow up on his other suggestions in the days and weeks
ahead.
Thanks too to Michael Snyder and J.T. Conklin for reviewing the patch
and doing further testing. Michael tested on both 32-bit and 64-bit
Solaris systems and J.T. tested on NetBSD/i386, on both a.out and ELF
systems.
Finally, thanks to Jim Blandy for discussing this patch with me and
for granting approval in a most timely fashion. Jim suggested some
improvements too; the main one being that solib-svr4.c should be
split yet again with the SunOS support being moved to solib-sunos.c.
I completely agree with this suggestion and will attempt to find time
to do this.
Kevin