This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: Z packet change
- To: Mark Salter <msalter at redhat dot com>
- Subject: Re: Z packet change
- From: Fernando Nasser <fnasser at cygnus dot com>
- Date: Fri, 27 Oct 2000 14:50:39 +0000
- CC: gdb-patches at sourceware dot cygnus dot com
- Organization: Red Hat Canada Ltd. - Toronto
- References: <200010271317.e9RDHVL10194@deneb.localdomain>
Mark Salter wrote:
>
> The following patch changes the Z packet support for hw breakpoints to
> match the documentation. Its not clear to me if we should do this or
> change the documentation to make make the 'len' field optional. Some
> hw lets you specify a range for hw breakpoints and although gdb doesn't
> support that right now, it may in the future.
>
> --Mark
>
Mark,
Is this backwards compatible with old cygmon stubs, for instance?
Thanks,
Fernando
> 2000-10-27 Mark Salter <msalter@redhat.com>
>
> * remote.c (remote_remove_hw_breakpoint): Add 'len' field to Z packet.
> (remote_insert_hw_breakpoint): Ditto.
>
> Index: remote.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/remote.c,v
> retrieving revision 1.26
> diff -p -c -r1.26 remote.c
> *** remote.c 2000/10/23 22:49:28 1.26
> --- remote.c 2000/10/27 13:06:52
> *************** remote_insert_hw_breakpoint (CORE_ADDR a
> *** 4433,4439 ****
>
> addr = remote_address_masked (addr);
> p += hexnumstr (p, (ULONGEST) addr);
> ! *p = '\0';
>
> putpkt (buf);
> getpkt (buf, PBUFSIZ, 0);
> --- 4433,4439 ----
>
> addr = remote_address_masked (addr);
> p += hexnumstr (p, (ULONGEST) addr);
> ! sprintf (p, ",%x", len);
>
> putpkt (buf);
> getpkt (buf, PBUFSIZ, 0);
> *************** remote_remove_hw_breakpoint (CORE_ADDR a
> *** 4469,4475 ****
>
> addr = remote_address_masked (addr);
> p += hexnumstr (p, (ULONGEST) addr);
> ! *p = '\0';
>
> putpkt(buf);
> getpkt (buf, PBUFSIZ, 0);
> --- 4469,4475 ----
>
> addr = remote_address_masked (addr);
> p += hexnumstr (p, (ULONGEST) addr);
> ! sprintf (p, ",%x", len);
>
> putpkt(buf);
> getpkt (buf, PBUFSIZ, 0);
--
Fernando Nasser
Red Hat Canada Ltd. E-Mail: fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario M4P 2C9