This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH RFC] Protoize top.c, ui-out.c
- To: Kevin Buettner <kevinb at cygnus dot com>
- Subject: Re: [PATCH RFC] Protoize top.c, ui-out.c
- From: Fernando Nasser <fnasser at cygnus dot com>
- Date: Sun, 29 Oct 2000 13:40:34 +0000
- CC: gdb-patches at sourceware dot cygnus dot com
- Organization: Red Hat Canada Ltd. - Toronto
- References: <1001028224354.ZM8539@ocotillo.lan>
I believe the protoization is pre-approved, isn't it? We all want that.
I guess we are supposed to double check and see if the script did a nice job
or if we have a major checkin that will be made hard by it.
It seems that the script did a nice job and I have already checked in some
changes, so please go on.
Note that the code at line 1643 of top.c is Elena's responsibility.
F.
Kevin Buettner wrote:
>
> * top.c (simplified_command_loop, add_info, add_com,
> help_command): Protoize.
> * ui-out.c (gdb_query): Protoize.
>
> Index: top.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/top.c,v
> retrieving revision 1.18
> diff -u -r1.18 top.c
> --- top.c 2000/10/23 22:49:28 1.18
> +++ top.c 2000/10/28 22:23:54
> @@ -1643,9 +1643,8 @@
> such things as displaying time and space usage. If the user asks
> for those, they won't work. */
> void
> -simplified_command_loop (read_input_func, execute_command_func)
> - char *(*read_input_func) (char *);
> - void (*execute_command_func) (char *, int);
> +simplified_command_loop (char *(*read_input_func) (char *),
> + void (*execute_command_func) (char *, int))
> {
> struct cleanup *old_chain;
> char *command;
> @@ -2871,10 +2870,7 @@
> /* Add an element to the list of info subcommands. */
>
> struct cmd_list_element *
> -add_info (name, fun, doc)
> - char *name;
> - void (*fun) (char *, int);
> - char *doc;
> +add_info (char *name, void (*fun) (char *, int), char *doc)
> {
> return add_cmd (name, no_class, fun, doc, &infolist);
> }
> @@ -2935,11 +2931,8 @@
> /* Add an element to the list of commands. */
>
> struct cmd_list_element *
> -add_com (name, class, fun, doc)
> - char *name;
> - enum command_class class;
> - void (*fun) (char *, int);
> - char *doc;
> +add_com (char *name, enum command_class class, void (*fun) (char *, int),
> + char *doc)
> {
> return add_cmd (name, class, fun, doc, &cmdlist);
> }
> @@ -2959,11 +2952,12 @@
> error ("Argument required (%s).", why);
> }
>
> +/* Provide documentation on command or list given by COMMAND. FROM_TTY
> + is ignored. */
> +
> /* ARGSUSED */
> static void
> -help_command (command, from_tty)
> - char *command;
> - int from_tty; /* Ignored */
> +help_command (char *command, int from_tty)
> {
> help_cmd (command, gdb_stdout);
> }
> Index: ui-out.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/ui-out.c,v
> retrieving revision 1.4
> diff -u -r1.4 ui-out.c
> --- ui-out.c 2000/07/30 01:48:27 1.4
> +++ ui-out.c 2000/10/28 22:23:54
> @@ -542,10 +542,7 @@
> }
>
> void
> -gdb_query (uiout, qflags, qprompt)
> - struct ui_out *uiout;
> - int flags;
> - char *qprompt;
> +gdb_query (struct ui_out *uiout, int qflags, char *qprompt)
> {
> }
> #endif
--
Fernando Nasser
Red Hat Canada Ltd. E-Mail: fnasser@redhat.com
2323 Yonge Street, Suite #300
Toronto, Ontario M4P 2C9