This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA]: Changes to move dcache above target vector functions.
- To: jtc at redback dot com
- Subject: Re: [RFA]: Changes to move dcache above target vector functions.
- From: Andrew Cagney <ac131313 at cygnus dot com>
- Date: Wed, 01 Nov 2000 22:30:33 +1100
- Cc: gdb-patches at sourceware dot cygnus dot com
- References: <5md7hjnd5v.fsf@jtc.redback.com>
"J.T. Conklin" wrote:
>
> Early last month, I trolled for comments about the enclosed patch.
> The only bite I got was about my suggestion that reset is a higher
> level concept and probably deserves a separate command / target
> function.
>
> I'd seeking approval to commit the enclosed patch. It's the same as
> the earlier one, except I "fixed" the problem with invalidating the
> dcache in ocd.c's bdm_reset_command(). This was fixed by accessing
> target_dcache in ocd.c. This is an abstraction layer violation, but
> it seemed the most expedient way to handle the problem. Support for a
> reset command would make this hack unnecessary. I'm open to changing
> this if necessary.
This is certainly ok with me. As they say two giant leaps forward and a
small step back.
Just mention the reset command issue (with a URL link) in the TODO file.
Andrew
(Yes I did notice the pre-existing goto :-)