This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] Implement auto-solib-add for AIX3/4, cleanup of shlib code.
- To: "Peter.Schauer" <Peter dot Schauer at Regent dot E-Technik dot TU-Muenchen dot DE>, gdb-patches at sourceware dot cygnus dot com
- Subject: Re: [RFA] Implement auto-solib-add for AIX3/4, cleanup of shlib code.
- From: Kevin Buettner <kevinb at cygnus dot com>
- Date: Sun, 5 Nov 2000 23:19:10 -0700
- Cc: nsd at redhat dot com
- References: <200011051221.NAA22174@reisser.regent.e-technik.tu-muenchen.de>
On Nov 5, 1:21pm, Peter.Schauer wrote:
> As the AIX5 shared library stuff seems to be quite different from AIX3/4,
> and Kevin Buettner encouraged me to proceed with fixing/enhancing the
> AIX3/4 code, I'd like to propose the following changes:
>
> Add auto-solib-add support for AIX, remove obsolete and unused
> SOLIB_SYMBOLS_MANUAL code, cleanup of AIX shared library handling code.
> * rs6000-nat.c (vmap_symtab): Do not try to modify offsets
> if symbols are not yet loaded.
> (vmap_add_symbols): New function to add symbols for a vmap entry.
> (add_vmap): Turn errors into warnings, return NULL vmap upon
> failure. Add symbols via vmap_add_symbols only if requested.
> (xcoff_relocate_core): Allow debugging of core files without an
> executable file. Handle NULL returns from add_vmap gracefully.
> * xcoffsolib.c (solib_add): Remove, no longer needed.
> (solib_info): Do not check for new shared libraries if there is no
> inferior process.
> (sharedlibrary_command): Made static.
> Do not check for new shared libraries if there is no inferior process.
> Add symbols for requested shared libraries via vmap_add_symbols.
> (_initialize_solib): Add `set auto-solib-add' command.
> * xcoffsolib.h (vmap_add_symbols): Add prototype declaration.
>
> * config/rs6000/tm-rs6000.h (PC_LOAD_SEGMENT): Move from here ...
> * config/rs6000/nm-rs6000.h: ... to here, this is an AIX native
> feature.
> * config/powerpc/tm-macos.h, config/powerpc/tm-ppc-eabi.h,
> config/powerpc/tm-ppc-nw.h, config/rs6000/tm-rs6000ly.h:
> Remove #undef PC_LOAD_SEGMENT.
> * config/powerpc/aix.mt, config/rs6000/aix4.mt, config/rs6000/rs6000.mt
> (TDEPFILES): Move xcoffsolib.o from here ...
> * config/powerpc/aix.mh, config/rs6000/aix4.mh, config/rs6000/rs6000.mh
> (NATDEPFILES): ... to here, xcoffsolib.o contains AIX native code
> only.
> * rs6000-tdep.c: Remove #include xcoffsolib.h, no longer needed.
> * xcoffsolib.h (xcoff_relocate_symtab_hook): Remove declaration.
> * rs6000-nat.c (_initialize_core_rs6000): Remove setting of
> xcoff_relocate_symtab_hook, no longer needed.
> * xcoffsolib.c (solib_info, sharedlibrary_command): Remove
> xcoff_relocate_symtab_hook indirection, call xcoff_relocate_symtab
> directly, as xcoffsolib.c is now compiled in native AIX configurations
> only.
> * Makefile.in: Update dependencies for rs6000-tdep.o, rs6000-nat.o
> and xcoffsolib.o.
Peter,
As far as I'm concerned, these changes are approved. I don't know
that much about xcoffsolib.c though. From my perusal of past
ChangeLogs, it appears that you're better qualified than I am to be
the maintainer of this file. That said, I did look over your changes
to xcoffsolib.c and it all looks reasonable. As for the rest, I
heartily approve of all the cleaning up that you've done.
Thanks,
Kevin