Re: [RFA]: Fix partial symbol lookups

[Daniel Berlin <dberlin at redhat dot com>]

Michael Snyder <msnyder@redhat.com> writes:

> Christopher Faylor wrote:
> > 
> > On Wed, Nov 15, 2000 at 11:19:41AM -0800, Michael Snyder wrote:
> > >>>>I also corrected lookup_partial_symbol to binary search the global
> > >>>>table, regardless of language, since this is the part that had led me
> > >>>>to believe it had demangled names in it in the first place.
> > >>>
> > >>>Are you SURE that NO language puts mangled names in?
> > >>You mean demangled, and yes, i'm positive.
> > >
> > >Ah, but now Peter points out that this might not be true for HP.
> > 
> > How hard would it be to change the HP way of doing things?  It doesn't
> > seem right to have one host doing things differently from all of the
> > others.
> 
> It isn't right.  It's very wrong.
> 
> But we must still not break it.  Let's fix it if we can.

It should only involve changing the call to add_psymbol_to_list, and
not removing two parameters.

This shouldn't affect anything, unless HP is doing partial symbol
lookups on demangled names explicitly.
grep says:
[root@dan2 gdb]# grep lookup_partial_symbol *.c
symtab.c:static struct partial_symbol *lookup_partial_symbol (struct partial_symtab *,
symtab.c:    if (!ps->readin && lookup_partial_symbol (ps, name, 1, namespace))
symtab.c:    if (!ps->readin && lookup_partial_symbol (ps, name, 0, namespace))
symtab.c:lookup_partial_symbol (struct partial_symtab *pst, const char *name, int global,
symtab.c:    if (!ps->readin && lookup_partial_symbol (ps, name, 1, STRUCT_NAMESPACE))
symtab.c:    if (!ps->readin && lookup_partial_symbol (ps, name, 0, STRUCT_NAMESPACE))
symtab.c:    if (lookup_partial_symbol (pst, "main", 1, VAR_NAMESPACE))

So, they aren't.
Of course, grep lied earlier because i didn't even realize
add_psymbol_with_dem_name_to_list even existed, since i'd never seen
it called.

--Dan