This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: New port: CRIS architecture


Andrew Cagney wrote:
> 
> tm-cris.h:
>         I'm trying to figure out why it is needed.
>         The obvious problem is SOFTWARE_SINGLESTEP_P.
>         I'll fix that.
> 

Great, I'll await that before resubmitting.

>         Beyond that one, what else is needed?  I'd
>         like to see a second pure multi-arch target
>         in GDB so will help where needed.

Is REGISTER_BYTES_OK eligible for multi-arching? Since it only controls
the warning message about the g packet's size, I don't think I can argue
in favour of that.

I got rid of PROLOGUE_FIRSTLINE_OVERLAP (which actually relieved me from
an old breakpoint related FAIL in the DejaGnu testsuite), as well as
BPT_VECTOR since it doesn't seem to be used (though mentioned in the
online documentation).

The remaining things I can move to cris-tdep.c, which would make it pure
multi-arch.

> 
> cris-tdep.c:
>         It is preferable to have enums and
>         two line functions rather than macros.
>         They both make the long term job of
>         maintenance far easier.
> 
>         Other files have put __initialize*
>         and xxx_arch_init() at the end.  I'd
>         just suggest moving them.
> 

Ok, I will make those changes. Thanks.

-- 
Orjan Friberg              E-mail: orjan.friberg@axis.com
Axis Communications AB     Phone:  +46 46 272 17 68

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]