This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH]: Minor fix in blockframe.c


On Dec 11,  1:09pm, Michael Snyder wrote:

> When setting up a new frame_info object, just use memset to pre-zero
> it, rather than zeroing selected fields individually.  That way new ones
> won't get overlooked.
> 
> 2000-12-11  Michael Snyder  <msnyder@mvstp600e.cygnus.com>
> 
>         * blockframe.c (get_prev_frame): Zero all fields of prev by
>         default using memset (instead of one at a time).
> 
[...]
> !   /* Zero all fields by default.  */
> !   memset (prev, 0, sizeof (struct frame_info);
> ! 

It looks to me like you're missing a paren.  (No matter how trivial, I
think we should always do test builds first...)

Kevin

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]