This is the mail archive of the gdb-patches@sourceware.cygnus.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [PATCH] Comment out longest_raw_hex_string


Jim Kingdon wrote:
> 
> > The attatched comments out the function longest_raw_hex_string().  It
> > can be deleted in a month or so (although everyone things it isn't
> > used).
> 
> Not that it's a big deal, but in case you want my advice, I'd just
> delete longest_raw_hex_string now.  If there really is some reason to
> resurrect it, it is in CVS.  <cynical, but based on experience>To
> think that the #if 0 code would go away as soon as a month is, er,
> optimistic </cynical>.

Hopefully the ``FIXME <date>'' and the delete after <version> will stop
that :-)
Other #if0'd code I've come across didn't do that and no one knows when
it was done.

My main reason for leaving it around was becasue I know HP and Apple had
stuff that they would like to incorporate into gdb and may use that
function.

	Andrew

PS: I've this script that counts the number of ``FIXME: cagney''s and a
few other things.  I've a big incentive to fix it :-)

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]