Re: GDB patch for 167Bug

[Andrew Cagney <ac131313 at cygnus dot com>]

Charles-Antoine Gauthier wrote:
> 
> Attached is a patch to allow GDB 4.18 to write to the MVME167 through
> 167Bug. The MS command does not work; the MW command must be used.
> 
> The ChangeLog hunk has context from the RTEMS patches. It probably will
> not apply cleanly, but it is quite short.

As far as I know, GDB doesn't contain the file ``167bug-rom.c''. Could
this be a local version?

	Andrew

PS, FYI, when submitting patches, they shouldn't include a diff to the
ChangeLog, see ``submitting a patch'' in:
http://sourceware.cygnus.com/cgi-bin/cvsweb.cgi/~checkout~/src/gdb/CONTRIBUTE?content-type=text/x-cvsweb-markup&cvsroot=src

> 
>   ------------------------------------------------------------------------
> *** gdb-4.18/gdb/167bug-rom.c   Mon Mar  6 14:20:50 2000
> --- ../gdb/gdb/167bug-rom.c     Mon Mar  6 14:54:42 2000
> ***************
> *** 110,118 ****
>     m167bug_cmds.clr_break =   "nobr %x\r";                     /* clear a breakpoint */
>     m167bug_cmds.clr_all_break =   "nobr\r";                    /* clear all breakpoints */
>     m167bug_cmds.fill =   "bf %x:%x %x;b\r";            /* fill (start count val) */
> !   m167bug_cmds.setmem.cmdb =     "ms %x %02x\r";              /* setmem.cmdb (addr, value) */
> !   m167bug_cmds.setmem.cmdw =     "ms %x %04x\r";              /* setmem.cmdw (addr, value) */
> !   m167bug_cmds.setmem.cmdl =     "ms %x %08x\r";              /* setmem.cmdl (addr, value) */
>     m167bug_cmds.setmem.cmdll =     NULL;                       /* setmem.cmdll (addr, value) */
>     m167bug_cmds.setmem.resp_delim =     NULL;                  /* setreg.resp_delim */
>     m167bug_cmds.setmem.term =     NULL;                        /* setreg.term */
> --- 110,118 ----
>     m167bug_cmds.clr_break =   "nobr %x\r";                     /* clear a breakpoint */
>     m167bug_cmds.clr_all_break =   "nobr\r";                    /* clear all breakpoints */
>     m167bug_cmds.fill =   "bf %x:%x %x;b\r";            /* fill (start count val) */
> !   m167bug_cmds.setmem.cmdb =     "mw %x %02x;b\r";            /* setmem.cmdb (addr, value) */
> !   m167bug_cmds.setmem.cmdw =     "mw %x %04x;w\r";            /* setmem.cmdw (addr, value) */
> !   m167bug_cmds.setmem.cmdl =     "mw %x %08x;l\r";            /* setmem.cmdl (addr, value) */
>     m167bug_cmds.setmem.cmdll =     NULL;                       /* setmem.cmdll (addr, value) */
>     m167bug_cmds.setmem.resp_delim =     NULL;                  /* setreg.resp_delim */
>     m167bug_cmds.setmem.term =     NULL;                        /* setreg.term */
> *** gdb-4.18/gdb/ChangeLog      Mon Mar  6 15:38:40 2000
> --- ../gdb/gdb/ChangeLog        Mon Mar  6 16:33:39 2000
> ***************
> *** 1,3 ****
> --- 1,7 ----
> + 2000-03-06 Charles-Antoine Gauthier  <charles.gauthier@nrc.ca>
> +
> +       * 167bug-rom.c(init_m167bug_cmds): Change the write commands.
> +
>   Fri Aug  6 165:41:15 EDT 1999 Charles-A. Gauthier <charles.gauthier@iit.nrc.ca>
> 
>         * config/m68k/monitor.mt (TDEPFILES): Add 167bug-rom.o.