This is the mail archive of the gdb-patches@sourceware.cygnus.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

RFC: More fixes to insights ln -s


Hello,

The attatched patch makes the make target ``all-gdbtk'' which creates a
link more robust.  Fernando noted that it issued a warning when it
didn't need to.  It could also trip up if there was an invalid old link.

Ok?

	Andrew
Wed Mar 15 17:32:48 2000  Andrew Cagney  <cagney@b1.cygnus.com>

	* Makefile.in (all-gdbtk): Check for an existing link/directory.
  	Re-format warning message.

Index: Makefile.in
===================================================================
RCS file: /cvs/src/src/gdb/Makefile.in,v
retrieving revision 1.12
diff -p -r1.12 Makefile.in
*** Makefile.in	2000/03/04 07:11:38	1.12
--- Makefile.in	2000/03/15 07:09:53
*************** fork-child.o: fork-child.c gdb_wait.h $(
*** 1260,1273 ****
  	$(inferior_h) target.h terminal.h gdbthread.h gdb_string.h
  
  all-gdbtk:
! 	if test "$(LN_S)" = "ln -s" -a ! -d gdbtcl/images ; then \
! 	  echo linking ${srcdir}/gdbtk/library to gdbtcl ; \
! 	  $(LN_S) ${srcdir}/gdbtk/library gdbtcl ; \
! 	else \
! 	  echo Warning: Unable to link ${srcdir}/gdbtk/library to gdbtcl. ; \
! 	  echo "         " You will need to do a ; \
! 	  echo "         " make install before you are able to run the GUI. ; \
! 	fi
  
  clean-gdbtk:
  	rm -f gdbtcl
--- 1260,1278 ----
  	$(inferior_h) target.h terminal.h gdbthread.h gdb_string.h
  
  all-gdbtk:
! 	@if test ! -d gdbtcl/images ; then \
! 	  if test "$(LN_S)" = "ln -s" ; then \
! 	    echo linking ${srcdir}/gdbtk/library to gdbtcl ; \
! 	    rm -f gdbtcl ; \
! 	    test ! -r gdbtcl || exit 1 ; \
! 	    $(LN_S) ${srcdir}/gdbtk/library gdbtcl ; \
! 	  else \
! 	    echo "Warning:" ; \
! 	    echo "Unable to link ${srcdir}/gdbtk/library to gdbtcl." ; \
! 	    echo "You will need to do a \`make install' before you are" ; \
! 	    echo "able to run the GUI." ; \
! 	  fi ; \
! 	else true ; fi
  
  clean-gdbtk:
  	rm -f gdbtcl

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]