This is the mail archive of the gdb-patches@sourceware.cygnus.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: RFA: minor watchpoint code cleanup



> This is just a cosmetic change.  Let me know.
> 
> 2000-03-17  Jim Blandy  <jimb@redhat.com>
> 
> 	* i386v-nat.c (i386_insert_nonaligned_watchpoint): Use a
> 	two-dimensional array, instead of faking it with explicit index
> 	arithmetic.

While we are talking: someone (H.J. Lu?) suggested to make the
watchpoint insertion code common to all x86 targets.  What's the
current say-so on this?

It seems like a good idea to me.  In particular, i386v-nat.c could use
some of the trickery, bug-fixes and features from go32-nat.c ;-).
For example, note that the function which removes non-aligned
watchpoints, doesn't go through the same routine as the insert
function does (does that mean that nobody has ever tried to use non-
aligned watchpoints on SysV?).

(And go32-nat.c should probably get the same change as you did above.)

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]