This is the mail archive of the gdb-patches@sourceware.cygnus.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: RFA: minor watchpoint code cleanup


   Date: Sun, 19 Mar 2000 04:44:56 -0500 (EST)
   From: Eli Zaretskii <eliz@delorie.com>

   > This is just a cosmetic change.  Let me know.
   > 
   > 2000-03-17  Jim Blandy  <jimb@redhat.com>
   > 
   > 	* i386v-nat.c (i386_insert_nonaligned_watchpoint): Use a
   > 	two-dimensional array, instead of faking it with explicit index
   > 	arithmetic.

   While we are talking: someone (H.J. Lu?) suggested to make the
   watchpoint insertion code common to all x86 targets.  What's the
   current say-so on this?

I haven't yet looked into the HW watchpoints yet.  We probably could
use the same logic for choosing the appropriate debug registers, but
the way the registers are accessed wil differ considerably among the
various i386 targets.  When fiddling the code we should keep
multi-arch in mind.

Mark

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]