This is the mail archive of the gdb-patches@sourceware.cygnus.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [RFA]: Apropos patch


"Daniel Berlin+list.gdb-patches" wrote:
> 
> Okay, new patch attached that does as you ask.
> I added more testcases as well.

Just four more nits, and then I'll shut up.  First, put the void
return type of the functions on lines by themselves - we like
to find function names in column 1.  Second, the functions should
be static if possible, looks like the helper function can be at least.
Third, please add prototypes at the top of the file.  Finally,
the help string should probably be rephrased a bit - use the
word "matching" at least, and ideally say "regular expression".
Do help rbreak for an example.

> i now use "apropos <the handle regex>", "apropos apropos", and
> "apropos handle a signal", which tests all the various things that
> could go wrong (excluding screwing up your regex, which will properly
> give you the error from the regex engine), like making sure multiple
> word aproposes work, etc.

That's excellent - now the testsuite will help protect your new command
from bitrot...

Stan

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]