This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]

Re: Patch: grep ^func

To: Eli Zaretskii <eliz at is dot elta dot co dot il>
Subject: Re: Patch: grep ^func
From: Michael Snyder <msnyder at redhat dot com>
Date: Fri, 26 Jan 2001 09:15:29 -0800
CC: dhoward at cygnus dot com, gdb-patches at sourceware dot cygnus dot com
Organization: Red Hat
References: <Pine.SOL.3.91.1010125142123.14868E-100000@taarna.cygnus.com> <1438-Fri26Jan2001115856+0200-eliz@is.elta.co.il>

Eli Zaretskii wrote:

> In general, I think gratuitous changes in whitespace should be
> avoided, since they get in the way when you need to figure out what
> _real_ changes in the code happened since the last time you looked.

Strongly disagree.  Some of the code in GDB is a real mess, and
I am devoted to the goal that it will look better (as time 
becomes available.

Clean-up patches should be made separately from bug-fix
patches, but they should NOT be avoided.  CVS allows you
to separate them, Eli.  Avoiding doing clean-up because it
makes using diff more difficult would be a bad bad thing, 
IMO.

Follow-Ups:
- Re: Patch: grep ^func
  - From: Eli Zaretskii

References:
- Re: Patch: grep ^func
  - From: Don Howard
- Re: Patch: grep ^func
  - From: Eli Zaretskii

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]