This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [RFA]: Repost of grep ^func patch


On Jan 26, 12:24pm, Don Howard wrote:

> Index: gdbtypes.h
> ===================================================================
> RCS file: /cvs/src/src/gdb/gdbtypes.h,v
> retrieving revision 1.6
> diff -p -u -w -r1.6 gdbtypes.h
> --- gdbtypes.h	2000/09/02 00:05:43	1.6
> +++ gdbtypes.h	2001/01/26 19:44:38
> @@ -1,6 +1,7 @@
>  /* Internal type definitions for GDB.
> -   Copyright (C) 1992-1994, 1996, 1998-2000 Free Software Foundation, Inc.
> -   Contributed by Cygnus Support, using pieces from other GDB modules.
> +   Copyright (C) 1992-1994, 1996, 1998, 1999, 2000 Free Software
> +   Foundation, Inc.  Contributed by Cygnus Support, using pieces from
> +   other GDB modules.

Shouldn't that be...

   Copyright 1992, 1993, 1994, 1996, 1998, 1999, 2000, 2001
   Free Software Foundation, Inc.
   Contributed by Cygnus Support, using pieces from other GDB modules.

...which does the following:

  1) Remove the (C)
  2) List the 1992-1994 range explicitly.
  3) Add the missing 2001.
  4) Keep the newline structure intact.  (I agree with Eli on this point.)

[...]
> -extern void
> -smash_to_method_type (struct type *, struct type *, struct type *,
> +extern void smash_to_method_type (struct type *, struct type *, struct type *, 
>  		      struct type **);

For this one (and others like it), I'd prefer to see the trailing
``struct type**);'' reindented so that it lines up to match the rest
of the declaration.  I.e, it should end up looking like this:

extern void smash_to_method_type (struct type *, struct type *, struct type *, 
                                  struct type **);


> Index: i386v-nat.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/i386v-nat.c,v
> retrieving revision 1.7
> diff -p -u -w -r1.7 i386v-nat.c
> --- i386v-nat.c	2000/07/30 01:48:25	1.7
> +++ i386v-nat.c	2001/01/26 19:45:36
> @@ -1,5 +1,6 @@
> -/* Intel 386 native support for SYSV systems (pre-SVR4).
> -   Copyright (C) 1988, 89, 91, 92, 94, 96, 1998 Free Software Foundation, Inc.
> +/* Intel 386 native support for SYSV systems (pre-SVR4).  Copyright
> +   (C) 1988, 89, 91, 92, 94, 96, 1998, 2001 Free Software Foundation,
> +   Inc.

Again, try to keep the newline structure intact.  Personally, I'd
prefer to see it as follows:

/* Intel 386 native support for SYSV systems (pre-SVR4).
   Copyright 1988, 1989, 1991, 1992, 1994, 1996, 1998, 2001
   Free Software Foundation, Inc.

Kevin

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]