This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [rfa] Change line to long
- To: Kevin Buettner <kevinb at cygnus dot com>
- Subject: Re: [rfa] Change line to long
- From: Andrew Cagney <ac131313 at cygnus dot com>
- Date: Thu, 01 Feb 2001 12:48:36 -0800
- Cc: GDB Patches <gdb-patches at sourceware dot cygnus dot com>
- References: <3A79B3DF.AADED074@cygnus.com> <1010201202450.ZM24092@ocotillo.lan>
Kevin Buettner wrote:
> Changing the type of ``line'' to long is probably a good idea anyway,
> but the code which calls record_line() in os9kread.c just looks wrong
> to me. I guess I'd prefer to see this bit of code in os9kread.c
> done correctly, but if it really is on its last legs, then perhaps
> it's not worth it. You might want to poke around www.microware.com
> for a minute or two to verify that it's really on its last legs. (I
> used os9k not too long ago.)
Even if I tried to do it correctly, I'd have no way to test it. I
should be trying to avoid non-mechanical changes to code I can't test.
My only other pratical alternative is to stop copmiling os9kread.c with
-Werror (there are mechanisms in Makefile.in for doing this) and several
other files have already been ``fixed'' this way :-)
> if (line == 0xffff)
> {
> return;
> }
Someone should add a FIXME to this bit of code.
> I notice in dwarf2read.c and dwarfread.c that an unsigned long is
> being passed to record_line(). Is there any reason not to make the
> type of ``line'' an unsigned long?
Good point.
Andrew