This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [patch] to gdb: portability fix: <sys/file.h>


Eli Zaretskii <eliz@is.elta.co.il> wrote:

> In other words, Posix platforms should not be forced in yet another 
> Autoconf test if we can avoid that.  IMHO, of course.

I don't see how you are avoiding yet another Autoconf test. My patch adds the
test for <sys/file.h> to configure.in so that I can check HAVE_SYS_FILE_H.
However, what you are proposing in another message:

> #if HAVE_UNISTD_H
> #include <unistd.h>
> #endif
>
> #ifndef F_OK
> # if HAVE_SYS_FILE_H
> /* 4.3BSD has F_OK in sys/file.h.  */
> #  include <sys/file.h>
> # endif
> # ifndef F_OK
> #  define F_OK 0
> # endif
> #endif

has to check HAVE_SYS_FILE_H too, so I don't see how it is different or how are
you avoiding "forcing in yet another Autoconf test".

-- 
Michael Sokolov
Public Service Agent
International Engineering and Science Task Force

1351 VINE AVE APT 27		Phone: +1-714-738-5409
FULLERTON CA 92833-4291 USA	(home office)

E-mail: msokolov@ivan.Harhan.ORG (ARPA TCP/SMTP)

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]