This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [RFA]: Convert the last FP opcode saved by FSAVE into a full opcode


> So I don't understand why you're missing those bits in the output of
> "info float".  I guess that you want "p $fop" to print the full opcode
> too (without the missing bits).  Back when I wrote the code I
> deliberately chose to let GDB's registers contain the raw register
> contents, and let the "info float" command interpret those things.
> That's why I didn't include those bits.  I'm also somewhat concerned
> about consistency between the various x86 targets.  If we apply your
> patch, targets that don't use the functions from i387-nat.c still
> won't include the extra bits.

This, for the moment, is probably the best compromise.

The register buffer should contain the raw and not the cooked/pseudo
information.  Instead that information should be constructed when
needed.

In theory, the info_registers() function should be implemented using
some sort of read register from frame function.  Unfortunatly, the
current interfaces are not advanced enough to accomodate this.

See the TODO file for some bad ascii art that explains the problem a
little.

	Andrew


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]