This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
[fyi] fix mips-tdep.c -Wprintf(a?"%d":"%d%d", ...)
- To: GDB Patches <gdb-patches at sourceware dot cygnus dot com>
- Subject: [fyi] fix mips-tdep.c -Wprintf(a?"%d":"%d%d", ...)
- From: Andrew Cagney <ac131313 at cygnus dot com>
- Date: Tue, 20 Feb 2001 18:47:23 -0500
Hello,
I've checked in the attatched. A GCC variant didn't like conditional
formats vis:
printf (cond ? "arg1=%d" : "arg1=%d arg2+%d", arg1, arg2);
(can't say that I like them much either mind :-)
Andrew
2001-02-20 Andrew Cagney <ac131313@redhat.com>
* mips-tdep.c (do_fp_register_row, do_fp_register_row): Fix printf
formatting.
Index: mips-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/mips-tdep.c,v
retrieving revision 1.41
diff -p -r1.41 mips-tdep.c
*** mips-tdep.c 2001/02/20 03:38:32 1.41
--- mips-tdep.c 2001/02/20 23:39:15
*************** do_fp_register_row (int regnum)
*** 2677,2688 ****
flt2 = unpack_double (builtin_type_float, raw_buffer[LO], &inv2);
doub = unpack_double (builtin_type_double, dbl_buffer, &inv3);
! printf_filtered (inv1 ? " %-5s: <invalid float>" :
! " %-5s%-17.9g", REGISTER_NAME (regnum), flt1);
! printf_filtered (inv2 ? " %-5s: <invalid float>" :
! " %-5s%-17.9g", REGISTER_NAME (regnum + 1), flt2);
! printf_filtered (inv3 ? " dbl: <invalid double>\n" :
! " dbl: %-24.17g\n", doub);
/* may want to do hex display here (future enhancement) */
regnum += 2;
}
--- 2677,2701 ----
flt2 = unpack_double (builtin_type_float, raw_buffer[LO], &inv2);
doub = unpack_double (builtin_type_double, dbl_buffer, &inv3);
! printf_filtered (" %-5s", REGISTER_NAME (regnum));
! if (inv1)
! printf_filtered (": <invalid float>");
! else
! printf_filtered ("%-17.9g", flt1);
!
! printf_filtered (" %-5s", REGISTER_NAME (regnum + 1));
! if (inv2)
! printf_filtered (": <invalid float>");
! else
! printf_filtered ("%-17.9g", flt2);
!
! printf_filtered (" dbl: ");
! if (inv3)
! printf_filtered ("<invalid double>");
! else
! printf_filtered ("%-24.17g", doub);
! printf_filtered ("\n");
!
/* may want to do hex display here (future enhancement) */
regnum += 2;
}
*************** do_fp_register_row (int regnum)
*** 2694,2704 ****
flt1 = unpack_double (builtin_type_float,
&raw_buffer[HI][offset], &inv1);
doub = unpack_double (builtin_type_double, dbl_buffer, &inv3);
! printf_filtered (inv1 ? " %-5s: <invalid float>" :
! " %-5s flt: %-17.9g", REGISTER_NAME (regnum), flt1);
! printf_filtered (inv3 ? " dbl: <invalid double>\n" :
! " dbl: %-24.17g\n", doub);
/* may want to do hex display here (future enhancement) */
regnum++;
}
--- 2707,2726 ----
flt1 = unpack_double (builtin_type_float,
&raw_buffer[HI][offset], &inv1);
doub = unpack_double (builtin_type_double, dbl_buffer, &inv3);
+
+ printf_filtered (" %-5s: ", REGISTER_NAME (regnum));
+ if (inv1)
+ printf_filtered ("<invalid float>");
+ else
+ printf_filtered ("flt: %-17.9g", flt1);
+
+ printf_filtered (" dbl: ");
+ if (inv3)
+ printf_filtered ("<invalid double>");
+ else
+ printf_filtered ("%-24.17g", doub);
! printf_filtered ("\n");
/* may want to do hex display here (future enhancement) */
regnum++;
}