This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH] New C++ abstraction patch
Andrew Cagney <ac131313@cygnus.com> writes:
> Daniel Berlin wrote:
> >
> > Michael Elizabeth Chastain <chastain@cygnus.com> writes:
> >
> > > Hi Daniel,
> > >
> > > I have some comments on your patch.
> > >
> > > Michael
> > >
> > > ===
> > >
> > > + gnu-v3-abi.o: gnu-v3-abi.c cp-abi.h
> > > +
> > > + gnu-v2-abi.o: gnu-v2-abi.c cp-abi.h
> > > +
>
> FYI,
>
> The convention (and yes it is gross) is:
>
> cp-abi_h = cp-abi.h
> ....
> gnu-v3-abi.o: $(defs_h) $(cp-abi_h) ...
>
> (I think ``cp-abi_h'' is a valid Makefile macro). When things get
> converted to automake this will all go away.
>
I did this at first, but it seemed those only happened for certain
headers (something to do with $(SRCDIR)), so I undid it before
submitting the patch.
I'll redo it.
--Dan