This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: PATCH: gdb/corefile.c (0401 snap on HP-UX).


>>>>> "Daniel" == Daniel Berlin <dan@cgsoftware.com> writes:
>> I'm not sure that I like this patch, but I'm not sure I can come up
>> with a resonable alternative in the short term.  Perhaps the code to
>> find the symbol file cooresponding to the core file (this is the bit
>> that needs symfile_objfile) should be replaced with a config specific
>> hook.  But because it is also wrapped with HPUXHPPA, I'm not opposed
>> to checking this in now, and fixing it up later.

Dan> Please don't.

See my response to Kevin.  In short, I'm not going to.

Dan> The idea is not to *add* things wrapped with HPUXHPPA, rather,
Dan> remove them.  Pretending they will be fixed up later isn't a
Dan> good idea. They haven't been thus far. There is no indication
Dan> this will change.

You don't need to lecture me about this.  I've been one of the most
vocal critics about adding cruft believing the fiction we'll fix it
later.  This is why I asked for further comments instead of commit-
ing the patch as is.  

        --jtc

-- 
J.T. Conklin
RedBack Networks


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]