This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [PATCH] Add control variable for debug output to linux threads
Date: Fri, 27 Apr 2001 14:26:15 -0700
From: Kevin Buettner <kevinb@cygnus.com>
Cc: Mark Kettenis <kettenis@science.uva.nl>, gdb-patches@sources.redhat.com
Content-Type: text/plain; charset=us-ascii
On Apr 26, 4:13pm, Michael Snyder wrote:
> This patch replaces your DEBUG macro with a runtime variable that is
> settable by a user command. At some recent check-in, you left the
> DEBUG macro turned on, and users have been asking about the extra
> messages.
>
> 2001-04-26 Michael Snyder <msnyder@redhat.com>
>
> * thread-db.c (_initialize_thread_db): Add set/show command
> "debug-linux-threads" for debugging output.
> * lin-lwp.c (various): Use global "debug_linux_threads to
> turn on extra debugging output.
Michael,
I have problems with your patch since it does a bit more than
advertised.
Apart from that, I'm having some trouble with the fact that the
set/show command is added to thread-db.c (the user threads library
layer, that in principle isn't Linux-specific) while the debug code
that it enables is code for the Linux-specific kernel threads (LWP)
support code that lives in lin-lwp.c.
Michael, may I suggest reverting this patch and discussing it next
week? I've got a train to catch now, so I'm a bit in a hurry.
Mark