Re: [RFA] gdb.base/callfuncs.exp: make all test names unique

[Michael Snyder <msnyder at cygnus dot com>]

Michael Elizabeth Chastain wrote:
> 
> This patch changes gdb.base/callfuncs.exp to make all test names unique.
> 
> Testing: I tested this on native Red Hat Linux 7 and native Solaris 2.8.
> 
> OK to apply?
> 
> Michael

Michael, this is great, but see below:

> 
> ===
> 
> 2001-05-19  Michael Chastain  <chastain@redhat.com>
> 
>         * gdb.base/callfuncs.exp: Make all test names unique.
> 
> Index: gdb/testsuite/gdb.base/callfuncs.exp
> ===================================================================
> RCS file: /cvs/src/src/gdb/testsuite/gdb.base/callfuncs.exp,v
> retrieving revision 1.4
> diff -c -3 -p -r1.4 callfuncs.exp
> *** gdb/testsuite/gdb.base/callfuncs.exp        2001/03/06 08:21:50     1.4
> --- gdb/testsuite/gdb.base/callfuncs.exp        2001/05/20 05:39:03
> *************** if { $hp_aCC_compiler } {
> *** 292,299 ****
> 
>   # Make sure that malloc gets called and that the floating point unit
>   # is initialized via a call to t_double_values.
> ! gdb_test "next" "t_double_values\\(double_val1, double_val2\\);.*"
> ! gdb_test "next" "t_structs_c\\(struct_val1\\);.*"
> 
>   # Save all register contents.
>   do_get_all_registers
> --- 292,299 ----
> 
>   # Make sure that malloc gets called and that the floating point unit
>   # is initialized via a call to t_double_values.
> ! gdb_test "next" "t_double_values\\(double_val1, double_val2\\);.*" "next 1"
> ! gdb_test "next" "t_structs_c\\(struct_val1\\);.*" "next 2"
> 
>   # Save all register contents.
>   do_get_all_registers

I wonder if it would not be preferable to use "next over t_double_values"
and "next over t_structs_c".  Since you are proposing to do a lot of these
mods, I have some concern about the testsuite becoming filled with names
such as "next 1" and "next 2" which, although practically speaking just as
useful, are somewhat opaque.