This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFC]: Greatly speed symbol lookups
- To: Daniel Berlin <dan at cgsoftware dot com>
- Subject: Re: [RFC]: Greatly speed symbol lookups
- From: jtc at redback dot com (J.T. Conklin)
- Date: 31 May 2001 14:39:44 -0700
- Cc: gdb-patches at sources dot redhat dot com
- References: <871yp5jl3w.fsf@dynamic-addr-83-177.resnet.rochester.edu>
- Reply-To: jtc at redback dot com
>>>>> "dan" == Daniel Berlin <dan@cgsoftware.com> writes:
Just a nit, but why the change from xfree() to free()? In the recent
past, we've been changing the remaining calls to free() to xfree().
If this code was to change, I'd think that we'd take advantage of the
behavior of xfree() and do something like:
xfree (subfile->name);
xfree (subfile->dirname);
xfree (subfile->line_vector);
xfree (subfile->debugformat);
nextsub = subfile->next;
xfree (subfile);
dan> *** 995,1017 ****
dan> }
dan> if (subfile->name != NULL)
dan> {
dan> ! xfree ((void *) subfile->name);
dan> }
dan> if (subfile->dirname != NULL)
dan> {
dan> ! xfree ((void *) subfile->dirname);
dan> }
dan> if (subfile->line_vector != NULL)
dan> {
dan> ! xfree ((void *) subfile->line_vector);
dan> }
dan> if (subfile->debugformat != NULL)
dan> {
dan> ! xfree ((void *) subfile->debugformat);
dan> }
dan>
dan> nextsub = subfile->next;
dan> ! xfree ((void *) subfile);
dan> }
dan>
dan> /* Set this for the main source file. */
dan> --- 991,1013 ----
dan> }
dan> if (subfile->name != NULL)
dan> {
dan> ! free ((void *) subfile->name);
dan> }
dan> if (subfile->dirname != NULL)
dan> {
dan> ! free ((void *) subfile->dirname);
dan> }
dan> if (subfile->line_vector != NULL)
dan> {
dan> ! free ((void *) subfile->line_vector);
dan> }
dan> if (subfile->debugformat != NULL)
dan> {
dan> ! free ((void *) subfile->debugformat);
dan> }
dan>
dan> nextsub = subfile->next;
dan> ! free ((void *) subfile);
dan> }
--
J.T. Conklin
RedBack Networks