This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [DejaGnu] dejagnu patch for IEEE compile flags


On Fri, Jun 01, 2001 at 03:39:05PM -0700, Geoffrey Keating wrote:
 
> The attached patch is to parallel a change I'll make to the GCC
> testsuite.  It used to be that the IEEE FP tests of GCC used
> -ffloat-store unconditionally.  On nearly all systems, this is
> unnecessary.  The last straw was that we had a testcase, that depended
> on IEEE FP, but which failed without -ffloat-store on powerpc and
> passed with it.

  Wouldn't it be good to see why this fails ? :-) This could also be
marked as a XFAIL till it's fixed.

> This adds -ffloat-store to ieee_multilib_flags for x86, just as -mieee
> is added for Alpha.  -ffloat-store is apparently also needed for m68k
> platforms older than the 68040, but I don't think we have any
> baseboards that are always like that, so it will need to be added in

  I still have several mc68020 and mc68010 VME boards here I use occasionally.
I'd prefer to see this change be in the gcc.c-torture/execute/ieee/ieee.exp
file, at just one place, rather than putting it in multiple files. There is
even support for it there, just add your code that checks for the config
triplet there. Would that work for you ? I just hesitate to add this patch
to multipple files, when it would be easier to maintain by making 
-ffloat-store conditional, rather than unconditional for the only few test
cases that care.

	- rob -


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]