Re: [RFA] linespec.c change to stop "malformed template specification" error

[Jim Blandy <jimb at zwingli dot cygnus dot com>]

Daniel Berlin <dan@cgsoftware.com> writes:
> Jim Blandy <jimb@zwingli.cygnus.com> writes:
> > Daniel Berlin <dan@cgsoftware.com> writes:
> >> > So finding breakpoint names requires parsing (almost) arbitrary
> >> > expressions.
> >> Only if you allow arbitrary names.
> >> We don't.
> >> So this leaves allowing a superset.
> > 
> > Sorry, I don't understand what you mean.
> 
> We don't allow expressions inside the line specifications right now.
> 
> Try "break (5 < 10) ? 10 : 20".
> 
> So the trouble we run into right now is because due to us wanting to
> do good error messages, without any kind of a real parser, we
> sometimes incorrectly split out what the function name is from the
> rest of the line specification.

Either you're misunderstanding the case I'm trying to address, or I'm
misunderstanding what find_toplevel_char is searching for.  This is
the kind of confusion that generates dozens of mail messages, but
would take two seconds to straighten out in person.

Since the patch is approved either way (with appropriate changes to
the comment above find_toplevel_char), and I think we all basically
get what's going on, I'm not going to pursue this further.