This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [RFC] if (INNER_THAN (read_sp(), step_sp - 16))


Andrew Cagney wrote:
> 
> > But I have no idea how to detect the situation that you are
> > trying to test for.  So I'd like to toss it back to you.
> > Can you find a better way to test for this?  Maybe with
> > (ugh) another state variable?
> >
> > And if not, can you put those two lines into an ifdef,
> > so they won't affect targets for which they're not intended?
> 
> Well it can't be a (ugh) #ifdef :-)

Not even to temporarily circumvent a known bug?
I understand your objection (multi-arch, if not general
distaste), but there are lots of ifdefs in infrun.c already...

FYI, I was thinking along the lines of
	(currently_stepping (ecs)
#ifdef TM_i386SOL2_H
	&& !(step_range_end
	    && INNER_THAN (read_sp (), (step_sp - 16)))
#endif
	));

which would preserve the behavior on x86 solaris, while
protecting the rest of the world until Peter can come up
with a better implementation.

Michael


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]