Re: PATCH: solib-svr4.c needs to know what DT_MIPS_RLD_MAP is

[Kevin Buettner <kevinb at cygnus dot com>]

On Jun 8,  2:07pm, Daniel Jacobowitz wrote:

> A block in solib-svr4.c is #ifdef'd on DT_MIPS_RLD_MAP, which is defined in
> "elf/mips.h".  Including that file would probably help.  We could
> conditionally include this file based on target, but I just went by other
> files in GDB which referenced it and included it always.
> 
> How's this patch?

This patch is approved.  Let me know if you need me to check it in for
you.  (I would prefer to see your name added to the MAINTAINERS file
so that you can check it in yourself.)

Kevin

> 
> 2001-06-08  Daniel Jacobowitz  <drow@mvista.com>
> 	* solib-svr4.c: Include "elf/mips.h".
> 	(elf_locate_base): Make DT_MIPS_RLD_MAP block unconditional. 
> 
> -- 
> Daniel Jacobowitz                           Debian GNU/Linux Developer
> Monta Vista Software                              Debian Security Team
> 
> [ text/plain ] :
> 
> 2001-06-08  Daniel Jacobowitz  <drow@mvista.com>
> 	* solib-svr4.c: Include "elf/mips.h".
> 	(elf_locate_base): Make DT_MIPS_RLD_MAP block unconditional.
> 
> Index: gdb/solib-svr4.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/solib-svr4.c,v
> retrieving revision 1.15
> diff -u -p -r1.15 solib-svr4.c
> --- solib-svr4.c	2001/05/04 04:15:27	1.15
> +++ solib-svr4.c	2001/06/08 21:05:02
> @@ -37,6 +37,7 @@
>  #else
>  #include "elf/external.h"
>  #include "elf/common.h"
> +#include "elf/mips.h"
>  #endif
>  
>  #include "symtab.h"
> @@ -623,7 +624,6 @@ elf_locate_base (void)
>  				      (bfd_byte *) x_dynp->d_un.d_ptr);
>  	      return dyn_ptr;
>  	    }
> -#ifdef DT_MIPS_RLD_MAP
>  	  else if (dyn_tag == DT_MIPS_RLD_MAP)
>  	    {
>  	      char *pbuf;
> @@ -637,7 +637,6 @@ elf_locate_base (void)
>  		return 0;
>  	      return extract_unsigned_integer (pbuf, sizeof (pbuf));
>  	    }
> -#endif
>  	}
>      }
>    else /* 64-bit elf */