This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] mips32_next_pc overdue cleanup
- To: Daniel Jacobowitz <dmj+ at andrew dot cmu dot edu>
- Subject: Re: [RFA] mips32_next_pc overdue cleanup
- From: Andrew Cagney <ac131313 at cygnus dot com>
- Date: Fri, 06 Jul 2001 01:22:35 -0400
- Cc: gdb-patches at sources dot redhat dot com
- References: <20010704114147.A15695@nevyn.them.org>
> This patch is half style cleanups and half obvious fixes, but there's so
> many I'd appreciate more eyes. According to the masks in the opcodes
> directory, these changes are rigt, and what we had before can't possibly
> work. Especially the fact that we would never, ever predict a BNE as taken
> before these changes convinced me that they really were correct and this
> code had never been particularly tested. Comments?
Approved.
History? It pre-dates my MIPS hacking :-) Dig dig, ah, it started out
as part of some prototyping that wasn't finished It was added in '98.
The WinCE GDB port ended up using it so I suspect it was made to mostly
work. The main reason the code worked is because it didn't bother to
use the broken macros that were added at the same time as the original
code :-/
Andrew