This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: [rfa] gdbserver 2/n - signals


On Jul 19,  2:17pm, Daniel Jacobowitz wrote:

> > o 
> > I don't understand the need for the file
> > 	gdbserver/signals.c.  Isn't that what
> > 	gdb/signals.c is for?
> 
> I was going to use that, except for a few small problems:
>  - wasted space, a couple of functions and the large name table.
>    I'm not really bothered by this one.
>  - warning() and internal_error() calls, which gdbserver doesn't
>    provide.
> 
> Perhaps re-using it despite those minor hurdles would be wiser.  I'll
> tweak the patch.

I'm not convinced that it's a good idea to share code between gdb and
gdbserver.  The problem with sharing code is that it's really easy to
break gdbserver if you're not careful.  I think it might be better to
revamp gdbserver so that it shares no code in common with gdb.

The other alternative is to go to the other extreme and attempt to do
maximal sharing.  But I think this will be harder to do and I suspect
the end result will be much less useful than some people think.  I
used gdbserver a while back to do the initial development of the IA-64
port.  I really liked it that gdbserver was small and required very
little work to bring up on a new machine.  I think we should continue
to strive to keep gdbserver as small as possible.

Kevin


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]