This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: Re-submit: shared libraries and a remote target


> This patch supersedes http://sources.redhat.com/ml/gdb-patches/2001-07/msg00513.html.
> It has all of Elena's and Kevin's comments implemented.
> 
> 
>         * remote.c (remote_get_list_of_shared_libraries, find_file,
>         parse_string_from_server): New functions which support
>         an optional extension to the remote protocol.


Hmm, I suspect the ChangeLog needs to be fleshed out a little.

You didn't mention anything about the remote_protocol_qLibraries global 
variable or the associated functions.  This is a shame because all that 
is fine!


> +#include <string.h>


FYI, gdb uses "gdb_string.h".  Also mention this in the ChangeLog.


> +  remote_get_list_of_shared_libraries();


FYI ``foo ()'' not ``foo()''


> +static void
> +remote_get_list_of_shared_libraries (void)


These new function should be before _initialize*().

Taking a quick glance at the actual code, I suspect that once the 
protocol is sorted out much of this will be simplified.

	Andrew




Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]