Re: [RFA] enum enable

[Jim Blandy <jimb at zwingli dot cygnus dot com>]

Eli Zaretskii <eliz@is.elta.co.il> writes:

> 
> > From: Jim Blandy <jimb@zwingli.cygnus.com>
> > Date: 16 Jul 2001 17:04:34 -0500
> > 
> > Anyway, I get compilation errors with your patch.  There are uses of
> > the old struct tracepoint `enabled' member that your patch didn't
> > catch.
> > 
> > (Or I botched appyling the patch.)
> 
> I think one of the hunks for tracepoint.c didn't apply for you,
> because tracepoint.c has changed while I worked on this.
> 
> The modified patch is attached below.  With it, I patched and built
> yesterday's snapshot without any problems.
> 
> Since this is just a variable-renaming patch, I hope it can be
> approved soon.  Otherwise, I need a kludge in go32-nat.c to get it to
> compile, and an IDE used by DJGPP users (which links parts of GDB as
> its debugging engine) needs further kludges, due to conflicts with
> system headers.  I'd hate to go into release branch with these
> kludges.

(I'm sorry I've been slow to reply.  I moved last week.)

This patch still fails to build.  The code your patch forgets to
change has been present in the sources for over a year.  Did you do a
full rebuild?

Here are the error messages:

gcc -c -g -O2    -I. -I/home/jimb/cygnus/src/sourceware/gdb/main/src/gdb -I/home/jimb/cygnus/src/sourceware/gdb/main/src/gdb/config -DHAVE_CONFIG_H -I/home/jimb/cygnus/src/sourceware/gdb/main/src/gdb/../include/opcode -I/home/jimb/cygnus/src/sourceware/gdb/main/src/gdb/../readline/.. -I../bfd -I/home/jimb/cygnus/src/sourceware/gdb/main/src/gdb/../bfd  -I/home/jimb/cygnus/src/sourceware/gdb/main/src/gdb/../include -I../intl -I/home/jimb/cygnus/src/sourceware/gdb/main/src/gdb/../intl  -DMI_OUT=1 -DUI_OUT=1 -Wimplicit -Wreturn-type -Wcomment -Wtrigraphs -Wformat -Wparentheses -Wpointer-arith -Wuninitialized  /home/jimb/cygnus/src/sourceware/gdb/main/src/gdb/printcmd.c
/home/jimb/cygnus/src/sourceware/gdb/main/src/gdb/printcmd.c:115: field `status' has incomplete type
/home/jimb/cygnus/src/sourceware/gdb/main/src/gdb/printcmd.c: In function `display_command':
/home/jimb/cygnus/src/sourceware/gdb/main/src/gdb/printcmd.c:1436: `enabled' undeclared (first use in this function)
/home/jimb/cygnus/src/sourceware/gdb/main/src/gdb/printcmd.c:1436: (Each undeclared identifier is reported only once
/home/jimb/cygnus/src/sourceware/gdb/main/src/gdb/printcmd.c:1436: for each function it appears in.)
/home/jimb/cygnus/src/sourceware/gdb/main/src/gdb/printcmd.c: In function `do_one_display':
/home/jimb/cygnus/src/sourceware/gdb/main/src/gdb/printcmd.c:1547: `disabled' undeclared (first use in this function)
/home/jimb/cygnus/src/sourceware/gdb/main/src/gdb/printcmd.c: In function `disable_display':
/home/jimb/cygnus/src/sourceware/gdb/main/src/gdb/printcmd.c:1647: `disabled' undeclared (first use in this function)
/home/jimb/cygnus/src/sourceware/gdb/main/src/gdb/printcmd.c: In function `enable_display':
/home/jimb/cygnus/src/sourceware/gdb/main/src/gdb/printcmd.c:1703: `enabled' undeclared (first use in this function)
/home/jimb/cygnus/src/sourceware/gdb/main/src/gdb/printcmd.c: In function `disable_display_command':
/home/jimb/cygnus/src/sourceware/gdb/main/src/gdb/printcmd.c:1741: `disabled' undeclared (first use in this function)
make[1]: *** [printcmd.o] Error 1
make[1]: Leaving directory `/gnomon/jimb/cygnus/pentium3/sourceware/gdb/main/native/build/gdb'
make: *** [all-gdb] Error 2

Compilation exited abnormally with code 2 at Mon Jul 30 14:09:33