This is the mail archive of the
gdb-patches@sources.redhat.com
mailing list for the GDB project.
Re: [RFA] gdb-events.sh: event notifications w/o args
- To: <gdb-patches at sources dot redhat dot com>
- Subject: Re: [RFA] gdb-events.sh: event notifications w/o args
- From: Keith Seitz <keiths at cygnus dot com>
- Date: Fri, 10 Aug 2001 09:05:30 -0700 (PDT)
On Fri, 10 Aug 2001, Andrew Cagney wrote:
> Yes, ok (almost). Can you just change the ``if'' to use the:
>
> if test ...
> then
> ..
> fi
>
> rather than
>
> if test ...; then
> ..
> fi
>
> so that it is consistent with the rest of the file (unless you can find
> a GNU SH SCRIPT coding standard which indicates otherwize :-).
Did I do that! Sheesh. Sorry.
For the record, I've committed this patch:
Index: gdb-events.sh
===================================================================
RCS file: /cvs/src/src/gdb/gdb-events.sh,v
retrieving revision 1.9
diff -u -p -r1.9 gdb-events.sh
--- gdb-events.sh 2001/06/07 20:18:45 1.9
+++ gdb-events.sh 2001/08/10 16:03:11
@@ -419,11 +419,14 @@ function_list | while eval read $read
do
case "${class}" in
"f" )
- echo "struct ${function}"
- echo " {"
- echo " `echo ${formal} | tr '[,]' '[;]'`;"
- echo " };"
- echo ""
+ if test ${actual}
+ then
+ echo "struct ${function}"
+ echo " {"
+ echo " `echo ${formal} | tr '[,]' '[;]'`;"
+ echo " };"
+ echo ""
+ fi
;;
esac
done
@@ -441,7 +444,10 @@ function_list | while eval read $read
do
case "${class}" in
"f" )
- echo " struct ${function} ${function};"
+ if test ${actual}
+ then
+ echo " struct ${function} ${function};"
+ fi
;;
esac
done
@@ -517,15 +523,20 @@ do
case "${class}" in
"f" )
echo " case ${function}:"
- echo " vector->${function}"
- sep=" ("
- ass=""
- for arg in `echo ${actual} | tr '[,]' '[:]' | tr -d '[ ]'`; do
- ass="${ass}${sep}event->data.${function}.${arg}"
- sep=",
- "
- done
- echo "${ass});"
+ if test ${actual}
+ then
+ echo " vector->${function}"
+ sep=" ("
+ ass=""
+ for arg in `echo ${actual} | tr '[,]' '[:]' | tr -d '[ ]'`; do
+ ass="${ass}${sep}event->data.${function}.${arg}"
+ sep=",
+ "
+ done
+ echo "${ass});"
+ else
+ echo " vector->${function} ();"
+ fi
echo " break;"
;;
esac
> I'm also trying to remember if TR has any portability issues (not your
> problem but your patch reminded me :-)
It's always possible... FWIW, I checked the last patch I had on this file
(which did fiddle with tr) on many hosts, linux, hpux, aix,
solaris, cygwin, osf, and anything else I could get my hands on. It worked
(after much fiddling) on all of them.
Keith