This is the mail archive of the gdb-patches@sources.redhat.com mailing list for the GDB project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]

Re: RFA: correctly detect overlapping overlays



Andrew Cagney <ac131313@cygnus.com> writes:
> > But I do think it's a shame.  When layout can expose symmetry in what
> > you're doing, it makes it easier to read the code.
> 
> 
> Order it as:
> 
> 	start_a
> 	start_b
> 	end_a
> 	end_b

(Surely this horse isn't dead yet...)

Then you don't have the a->vma terms lining up, which show off the
fact that all the values are based on the section's VMA address.

Basically, there are two axes of symmetry: the fact that the *_a
computations are the same as those for *_b, and the fact that both the
end addresses are just the start addresses plus the size.  There's no
ordering that will show off both symmetries without custom
indentation.

But really, your change is fine with me.  I think the ability to
mechanically re-indent the code is valuable.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]