Re: [RFA] work around sigsetjmp/siglongjmp macro problems

[Christopher Faylor <cgf at redhat dot com>]

On Tue, Aug 14, 2001 at 04:09:42PM -0400, Elena Zannoni wrote:
>Keith Seitz writes:
> > On Mon, 13 Aug 2001, Christopher Faylor wrote:
> > 
> > > My proposed patch is below.  It may even be an obvious fix.
> > >
> > > Keith, could you try this out and verify that it fixes the problem?
> > 
> > Yep, works just fine.
> > 
> > Keith
>
>
>Ok, check it in.  I don't think there is need for comments.

Done.

>Maybe in the gdb coding style section of the gdb internal manual, we
>should make this point about macro's arguments.  Eli?

How about this:

Index: gdbint.texinfo
===================================================================
RCS file: /cvs/uberbaum/gdb/doc/gdbint.texinfo,v
retrieving revision 1.34
diff -p -r1.34 gdbint.texinfo
*** gdbint.texinfo	2001/07/31 17:30:56	1.34
--- gdbint.texinfo	2001/08/14 20:07:27
*************** However, use functions with moderation. 
*** 4395,4400 ****
--- 4395,4402 ----
  are just as hard to understand as a single thousand-line function.
  
  @emph{Macros are bad, M'kay.}
+ (But if you have to use a macro, make sure that the macro arguments are
+ protected with parentheses.)
  
  @cindex types
  
cgf